Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Return deltadata for DeleteCodec.Deserialize #37214

Merged
merged 1 commit into from
Oct 29, 2024
Merged

enhance: Return deltadata for DeleteCodec.Deserialize #37214

merged 1 commit into from
Oct 29, 2024

Conversation

congqixia
Copy link
Contributor

Related to #35303 #30404

This PR change return type of DeleteCodec.Deserialize from storage.DeleteData to DeltaData, which
reduces the memory usage of interface header.

Also refine storage.DeltaData methods to make it easier to usage.

@congqixia
enhance: Return deltadata for DeleteCodec.Deserialize
15e7e21 
Related to milvus-io#35303 milvus-io#30404

This PR change return type of `DeleteCodec.Deserialize`
from `storage.DeleteData` to `DeltaData`, which
reduces the memory usage of interface header.

Also refine `storage.DeltaData` methods to make it
easier to usage.

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Oct 28, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Oct 28, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 28, 2024

@congqixia cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 28, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 28, 2024

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Oct 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 89.33333% with 8 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@d8c1bd2). Learn more about missing BASE report.
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
internal/querynodev2/segments/segment_loader.go 37.50% 3 Missing and 2 partials ⚠️
internal/storage/data_codec.go 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37214   +/-   ##
=========================================
  Coverage          ?   80.84%           
=========================================
  Files             ?     1318           
  Lines             ?   182642           
  Branches          ?        0           
=========================================
  Hits              ?   147664           
  Misses            ?    29801           
  Partials          ?     5177
Components Coverage Δ
Client ∅ <ø> (?)
Core 66.89% <ø> (?)
Go 83.13% <89.33%> (?)
Files with missing lines Coverage Δ
internal/datanode/iterators/deltalog_iterator.go 100.00% <100.00%> (ø)
internal/querynodev2/segments/segment.go 65.47% <100.00%> (ø)
internal/querynodev2/segments/segment_l0.go 71.87% <100.00%> (ø)
internal/storage/delta_data.go 100.00% <100.00%> (ø)
internal/storage/primary_keys.go 100.00% <100.00%> (ø)
internal/storage/data_codec.go 77.79% <66.66%> (ø)
internal/querynodev2/segments/segment_loader.go 73.25% <37.50%> (ø)

@congqixia
Copy link
Contributor Author

rerun cpp-unit-test

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@congqixia
Copy link
Contributor Author

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 28, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@congqixia
Copy link
Contributor Author

rerun cpp-unit-test

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 29, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Oct 29, 2024
@tedxu
Copy link
Contributor

tedxu commented Oct 29, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 3106384 into milvus-io:master Oct 29, 2024
20 checks passed
congqixia added a commit to congqixia/milvus that referenced this pull request Oct 29, 2024
@congqixia
enhance: Return deltadata for DeleteCodec.Deserialize (milvus-io#37214
60ec291 
)

Related to milvus-io#35303 milvus-io#30404

This PR change return type of `DeleteCodec.Deserialize` from
`storage.DeleteData` to `DeltaData`, which
reduces the memory usage of interface header.

Also refine `storage.DeltaData` methods to make it easier to usage.

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this pull request Oct 29, 2024
Merged
sre-ci-robot pushed a commit that referenced this pull request Oct 30, 2024
@congqixia
enhance: [2.5] Return deltadata for DeleteCodec.Deserialize (#37214) (
ee6ce8c 
#37264)

Cherry pick from master
pr: #37214
Related to #35303 #30404

This PR change return type of `DeleteCodec.Deserialize` from
`storage.DeleteData` to `DeltaData`, which
reduces the memory usage of interface header.

Also refine `storage.DeltaData` methods to make it easier to usage.

Signed-off-by: Congqi Xia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aoiasd aoiasd Awaiting requested review from aoiasd

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

Assignees

@tedxu tedxu

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@congqixia @sre-ci-robot @tedxu